Re: JDK 8 Code Review Request: 7187962: sun.security.pkcs11.P11DSAKeyFactory.implTranslatePublicKey doesn't check if params is null

Mon, 06 Aug 2012 08:13:37 -0700 

On 08/06/2012 11:03 AM, Xuelei Fan wrote:

Does other JCE provider also need to check the parameter? For example,
sun.security.provider.DSAKeyFactory.



It already does. This fix makes the SunPKCS11 provider consistent with 
the SUN provider. See the sun.security.provider.DSA.setParams method:


private void setParams(DSAParams params) throws InvalidKeyException {
    if (params == null) {
        throw new InvalidKeyException("DSA public key lacks parameters");
    }
    ...

--Sean



Thanks,
Xuelei

On 8/6/2012 10:43 PM, Sean Mullan wrote:

Hi Valerie,

Could you please review this simple fix to
P11DSAKeyFactory.implTranslatePublicKey?

http://cr.openjdk.java.net/~mullan/webrevs/7187962/webrev.00/

Thanks,
Sean


























					Reply via email to