Sure, I have updated the webrev to expand ic into "iteration count" in
the exception message to be consistent of other existing exception messages.
Thanks for the quick review,
Valerie
On 05/08/13 10:30, Vincent Ryan wrote:
Your fix looks good.
Just a minor comment: should 'ic' be expanded to 'iteration count' in the
exception message
in HmacPKCS12PBESHA1.java and PBMAC1Core.java?
On 8 May 2013, at 02:08, Valerie (Yu-Ching) Peng wrote:
Vinnie,
Could you please help reviewing the fixes for 8013069 "javax.crypto tests fail with
new PBE algorithm names"?
Given that the current javax.crypto.Mac API doesn't provide a way to return
algorithm parameters (unlike most of other crypto engine classes), I think it's
better to error out when the needed parameters are missing.
Webrev: http://cr.openjdk.java.net/~valeriep/8013069/webrev.00/
Thanks!
Valerie
