On 07/03/2014 07:31, Wang Weijun wrote:
Hi All
Please take a review of
http://cr.openjdk.java.net/~weijun/8035963/webrev.00/
I've added a ratio variable to these timeout related tests. The ratio is now
set to 2 (one exception, 3 for BadKdc2). This is mainly an experiment to how if
they can be more stable when running slower. We will need to do some
observation for a period of time.
I don't know these tests but from what I can figure out then the changes
look reasonable. Style wise then I guess I probably would have added a
setter/getter for the ration rather than access it as a field but that
is a minor point.
One suggestion is to adding @build lines to each of the BadKdc{1,2,3}
tests as otherwise BadKdc will be compiled implicitly (this comments
isn't specific to the current patch because I see there is already a
dependency).
-Alan
