There are something I don't understand.
MyConfiguration.java:
- optionOrder: Is it possible to make this an argument of the constructor?
- getConfiguration/setConfiguration: If these are useless, why adding
these methods?
SmartLoginModule.java:
- initialize: Why don't you use the callbackHandler argument?
- shouldSucceed: It is always very confusing to make a field accessible
from outside a class.
DynamicConfigurationTest.java:
- test: why the if checks are based on both isNegative and success? Why
not only on isNegative? If you want to test 2 stages (initialize and
login), you can provide 2 isNegative flags.
Thanks
Max
On 08/17/2015 01:39 PM, Amanda Jiang wrote:
Hi All,
Please be free to review these new tests for Dynamic configuration of
authentication modules.
Bug: https://bugs.openjdk.java.net/browse/JDK-8050427
webrev:http://cr.openjdk.java.net/~amjiang/8050427/webrev.01/
Thanks,
Amanda
