Hi Max, thanks for that hint about correctly referencing the inner class. Now I could do it.
As for PrngSlow.java: By having a closer look, I discovered that the test was always running into an exception, as the algorithm name "PRNG" is not available for MSCAPI. I renamed it to the correct value of "Windows-PRNG" and now the test would run. I also cleaned the class and removed the exception handler so real exceptions should pop up now. Also, I completed adding the @requires tag for each test. This is the result: http://cr.openjdk.java.net/~clanger/webrevs/8139436.6/ Best regards Christoph -----Original Message----- From: Wang Weijun [mailto:weijun.w...@oracle.com] Sent: Samstag, 14. November 2015 03:32 To: Langer, Christoph <christoph.lan...@sap.com> Cc: Vincent Ryan <vincent.x.r...@oracle.com>; security-dev@openjdk.java.net Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data Hi Christoph I tried updating the entry line in TestProvider and it starts working. this.put("CertificateFactory.X.509", "IterateWindowsRootStore$TestFactory"); PrngSlow.java: Do you still need the "// Not supported here, maybe not a Win32" block? Is there other exception you want to ignore? I also notice @required is not used everywhere (For example, SignUsingNONEwithRSA.sh). I'm not a fan of fixing existing tests but since you started we can be more consistent. Thanks Max > On 2015年11月14日, at 上午7:54, Langer, Christoph <christoph.lan...@sap.com> wrote: > > Hi Max, > > I followed your suggestion to use a sub-directory. I found no way to make the > dummy JCE provider work with inner classes. > > Please see this (hopefully final) webrev: > http://cr.openjdk.java.net/~clanger/webrevs/8139436.5/ > > Best regards > Christoph > > -----Original Message----- > From: Wang Weijun [mailto:weijun.w...@oracle.com] > Sent: Freitag, 13. November 2015 17:08 > To: Langer, Christoph <christoph.lan...@sap.com> > Cc: Vincent Ryan <vincent.x.r...@oracle.com>; security-dev@openjdk.java.net > Subject: Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete > data > > It is my understanding that if you write multiple files for a single test, > they should be put inside a sub-directory. > > But in this case you can combine them into a single class by putting the > provider-related codes into static inner classes. > > --Max > > P. S. Sent from my iPhone so I haven't read all the changes. > >> 在 2015年11月13日，20:33，Langer, Christoph <christoph.lan...@sap.com> 写道： >> >> Is that ok now?
