On 02/25/2016 04:01 AM, Sibabrata Sahoo wrote:
Hello,

Please review the updated test to verify
“jdk.security.provider.preferred” security property in all platform.

Bug: https://bugs.openjdk.java.net/browse/JDK-8150512

Webrev: http://cr.openjdk.java.net/~ssahoo/8150512/webrev.00/

These test were initially planned to run on Solaris platform only. But
JDK-8133151 introduces “jdk.security.provider.preferred” security
property for all platform. So, the tests were modified accordingly for
this property verification.

Thanks,

Siba


Hi Siba,

Here are my comments...

- PreferredProviderTest.java:62-70
You appear to be missing SHA1 and SHA-224. They should be added to the preferredProp variable, and the verifyDigestProvider DataTuple's.


- PreferredProviderTest.java:75-76
This is calling MessageDigest with RSA as the algorithm, I would expect this to fail, but the test looks like it expects it to pass.
The original code was creating a KeyFactory for RSA which would pass.

thanks

Tony

Reply via email to