Hi, The updated changes look fine.
Thanks Tony On 03/15/2016 03:24 AM, Sibabrata Sahoo wrote:
Hi Anthony, Please find the updated webrev: http://cr.openjdk.java.net/~ssahoo/8150512/webrev.01/ Following comments associated. Thanks, Siba ------------------- Here are my comments... - PreferredProviderTest.java:62-70 You appear to be missing SHA1 and SHA-224. They should be added to the preferredProp variable, and the verifyDigestProvider DataTuple's. - PreferredProviderTest.java:75-76 This is calling MessageDigest with RSA as the algorithm, I would expect this to fail, but the test looks like it expects it to pass. The original code was creating a KeyFactory for RSA which would pass. thanks Tony