> On May 11, 2017, at 3:25 PM, Brent Christian <[email protected]>
> wrote:
>
> Hi,
>
> I have one more update, with a couple of suggested changes to simplify the
> execute() calls:
>
> * execute() takes a vararg, so explicit String[] creation can be omitted
> (mostly).
>
> * args common to every execute() call are consolidated into a List. (The
> resulting arg reordering should not affect test execution.)
>
> http://cr.openjdk.java.net/~bchristi/8177328/webrev.02/
This looks much cleaner. Thanks for the change.
Minor comment:
95 private final List<String> COMMON_ARGS;
This is an instance field and you can use lower case as the convention.
238 return !s.equals("");
You can consider using String::isEmpty.
No need for an updated webrev.
Thanks
Mandy
