Just a few comments:
- Update copyrights to include 2018
- I think you should also open a jarsigner docs issue to add new
warnings for expired TSA and expiring signer and TSA certs
* Main.java
l1740, typo: s/singer/signer/
--Sean
On 2/9/18 4:10 AM, Weijun Wang wrote:
Updated again at http://cr.openjdk.java.net/~weijun/8191438/webrev.05/.
--Max
On Jan 4, 2018, at 8:48 AM, Weijun Wang <[email protected]> wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8191438/webrev.04/
Major changes:
1. Warnings on TSA cert chain: expired or expiring
2. No more check on trusted certs
3. More output at signing when -verbose is on
4. Fine tune messages when TSA cert expires earlier than signer cert
5. New test cases
6. Existing tests modification so signer is not trusted
Thanks
Max