> On Feb 13, 2018, at 6:01 AM, Sean Mullan <sean.mul...@oracle.com> wrote:
> 
> Just a few comments:
> 
> - Update copyrights to include 2018

OK.

> - I think you should also open a jarsigner docs issue to add new warnings for 
> expired TSA and expiring signer and TSA certs

https://bugs.openjdk.java.net/browse/JDK-8197784 filed.

Please also review the release note subtask at 
https://bugs.openjdk.java.net/browse/JDK-8197783.

Thanks
Max

> 
> * Main.java
> 
> l1740, typo: s/singer/signer/
> 
> --Sean
> 
> 
> On 2/9/18 4:10 AM, Weijun Wang wrote:
>> Updated again at http://cr.openjdk.java.net/~weijun/8191438/webrev.05/.
>> --Max
>>> On Jan 4, 2018, at 8:48 AM, Weijun Wang <weijun.w...@oracle.com> wrote:
>>> 
>>> Please take a review at
>>> 
>>>  http://cr.openjdk.java.net/~weijun/8191438/webrev.04/
>>> 
>>> Major changes:
>>> 
>>> 1. Warnings on TSA cert chain: expired or expiring
>>> 
>>> 2. No more check on trusted certs
>>> 
>>> 3. More output at signing when -verbose is on
>>> 
>>> 4. Fine tune messages when TSA cert expires earlier than signer cert
>>> 
>>> 5. New test cases
>>> 
>>> 6. Existing tests modification so signer is not trusted
>>> 
>>> Thanks
>>> Max
>>> 

Reply via email to