> On Jun 11, 2018, at 10:32 PM, Xuelei Fan <xuelei....@oracle.com> wrote: > >> >> Another thing in CipherSuite.java: >> 803 static CipherSuite nameOf(String ciperSuiteName) { >> Why isn't this method named valueOf()? > There is a default builtin valueOf(String) method for enum type. Ah, I see. But given the return type is a value, maybe simply of()? nameOf() sounds like it would return a name. --Max
- Re: KRB5 (was Re: Code Review Reque... Xuelei Fan
- Re: KRB5 (was Re: Code Review Reque... Xuelei Fan
- Re: KRB5 (was Re: Code Review Reque... Weijun Wang
- Re: KRB5 (was Re: Code Review Reque... Xuelei Fan
- Re: KRB5 (was Re: Code Review Reque... Weijun Wang
- Re: KRB5 (was Re: Code Review Reque... Xuelei Fan
- Re: KRB5 (was Re: Code Review Reque... Weijun Wang
- Re: KRB5 (was Re: Code Review Reque... Xuelei Fan
- SSLContextImpl.java (was Re: Code R... Weijun Wang
- Re: SSLContextImpl.java (was Re: Co... Xuelei Fan
- Re: SSLContextImpl.java (was Re: Co... Weijun Wang
- Re: SSLContextImpl.java (was Re: Co... Xuelei Fan
- Re: SSLContextImpl.java (was Re: Co... Weijun Wang
- Re: SSLContextImpl.java (was Re: Co... Xuelei Fan
- Re: Module-info.hava (was Re: Code Review Re... Xuelei Fan
- Re: Code Review Request: TLS 1.3 Implementation Bradford Wetmore
- Re: Code Review Request: TLS 1.3 Implementation Bradford Wetmore
- Re: Code Review Request: TLS 1.3 Implementation Bradford Wetmore
- Re: Code Review Request: TLS 1.3 Implementat... Xuelei Fan
- Re: Code Review Request: TLS 1.3 Impleme... Bradford Wetmore
- Re: Code Review Request: TLS 1.3 Im... Xuelei Fan