On 6/11/2018 7:36 AM, Weijun Wang wrote:
On Jun 11, 2018, at 10:32 PM, Xuelei Fan <xuelei....@oracle.com> wrote:
Another thing in CipherSuite.java:
803 static CipherSuite nameOf(String ciperSuiteName) {
Why isn't this method named valueOf()?
There is a default builtin valueOf(String) method for enum type.
Ah, I see. But given the return type is a value, maybe simply of()?
nameOf() sounds like it would return a name.
I hesitated among nameOf(), ofName() and of() for a while. Good if you
have a preference. As there are a few more nameOf() methods defined in
other classes. I will find a chance to update them all.
Thanks,
Xuelei
