Hi Xuelei,
<src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java>
- line 2, why is the copyright year changed from 2015 only to 2003 and
2018? Don't we normally preserve the first year and only update/add the
second year?
- line 110, instead of erroring out, I wonder if it's better to call
createPossessions(handshakeContext) and only error out if the result is
more than one.
- line 421 and 464, RSA is left out for these two cases, is this
asymmetry (comparing to line 381 and 494) intentional?
<src/java.base/share/classes/sun/security/ssl/RSAServerKeyExchange.java>
- line 2, for a new file, shouldn't there be only one year, i.e. 2018?
- line 219, is this INSTANCE really used? I did a quick search and
didn't find reference to it.
- line 309, why is EC mentioned here? Typo perhaps?
<src/java.base/share/classes/sun/security/ssl/ServerKeyExchange.java>
- line 2, for a new file, shouldn't there be only one year, i.e. 2018?
- line 89, typo: "producing" should be "consuming"
- line 107, typo: "not" should be "no"
Thanks,
Valerie
On 5/25/2018 4:45 PM, Xuelei Fan wrote:
Hi,
I'd like to invite you to review the TLS 1.3 implementation. I
appreciate it if I could have compatibility and specification feedback
before May 31, 2018, and implementation feedback before June 7, 2018.
Here is the webrev:
http://cr.openjdk.java.net/~xuelei/8196584/webrev-full.00
The formal TLS 1.3 specification is not finalized yet, although it had
been approved to be a standard. The implementation is based on the
draft version 28:
https://tools.ietf.org/html/draft-ietf-tls-tls13-28
For the overall description of this enhancement, please refer to JEP 332:
http://openjdk.java.net/jeps/332
For the compatibility and specification update, please refer to CSR
8202625:
https://bugs.openjdk.java.net/browse/JDK-8202625
Note that we are using the sandbox for the development right now. For
more information, please refer to Bradford's previous email:
http://mail.openjdk.java.net/pipermail/security-dev/2018-May/017139.html
Thanks & Regards,
Xuelei
