> On Aug 13, 2018, at 10:00 PM, Xue-Lei Fan <xuelei....@oracle.com> wrote: > > Looks fine to me. > > Did you notice other places that might need similar update as well in > security components? One "new GetPropertyAction()" at String property = AccessController.doPrivileged( new GetPropertyAction("jdk.tls.namedGroups")); But I haven't checked for doPrivileged(()->System.getProperty()) calls. Thanks Max > > Thanks, > Xuelei > > > On 8/13/2018 3:24 AM, Weijun Wang wrote: >> Please take a review at >> http://cr.openjdk.java.net/~weijun/8209416/webrev.00/ >> This is all about refactoring "AccessController.doPrivileged(new >> GetPropertyAction(x))" into "GetPropertyAction.privilegedGetProperty(x)". >> I've already introduced a new GetBooleanAction::privilegedGetProperty method. >> Noreg-cleanup. >> Thanks >> Max
- RFR 8209416: Refactoring GetPropertyAction calls in JGSS Weijun Wang
- Re: RFR 8209416: Refactoring GetPropertyAction calls in ... Roger Riggs
- Re: RFR 8209416: Refactoring GetPropertyAction calls in ... Xue-Lei Fan
- Re: RFR 8209416: Refactoring GetPropertyAction calls... Weijun Wang
- Re: RFR 8209416: Refactoring GetPropertyAction c... Weijun Wang
- Re: RFR 8209416: Refactoring GetPropertyActi... Xue-Lei Fan
- Re: RFR 8209416: Refactoring GetPropert... Weijun Wang
- Re: RFR 8209416: Refactoring GetPro... Xue-Lei Fan
- Re: RFR 8209416: Refactoring GetPropertyAction calls in ... Sean Mullan
- Re: RFR 8209416: Refactoring GetPropertyAction calls... Weijun Wang
- Re: RFR 8209416: Refactoring GetPropertyAction calls... Alan Bateman
- Re: RFR 8209416: Refactoring GetPropertyAction c... Weijun Wang
- Re: RFR 8209416: Refactoring GetPropertyActi... Alan Bateman