On Wed, Oct 31, 2018 at 05:22:27PM +0800, Weijun Wang wrote: > > On Oct 30, 2018, at 10:28 PM, Sean Mullan <sean.mul...@oracle.com> wrote: > > > > I think you should put braces around the conditional statements on lines > > 332, 357, & 359. It would read better and avoid accidental bugs.
Is that part of a published Java style? (Personally, I dislike braces for single statement blocks. But we'll follow whatever style guide exists.) > > Where does delegatedCred get used? It seems to be never set. > > It's set in a native method Correct. > 322 outToken = cStub.acceptContext(pCred, cb, inToken, this); > > > Otherwise looks fine. You will need to add a noreg label if you can't write > > a test. > > Yes. Not sure what that means. Nico --
