On 11/1/18 4:19 AM, Weijun Wang wrote:

On Nov 1, 2018, at 5:25 AM, Nico Williams <nico.willi...@twosigma.com> wrote:

Otherwise looks fine. You will need to add a noreg label if you can't write a 
test.

Yes.

Not sure what that means.

https://openjdk.java.net/guide/changePlanning.html#noreg.

I'll add a noreg-hard due to complex setup.

*Sean*, I'll add the braces. Do you have other comments?

No, looks good.

--Sean

Reply via email to