I have read some but probably not as strictly as a reviewer. Anyway, let's start dealing with them one by one.
The following 2 lists should have the same orders. https://bugs.openjdk.java.net/issues/?jql=assignee%20%3D%20nwilliams%20ORDER%20BY%20key%20ASC http://cr.openjdk.java.net/~weijun/twosigma-gss/ Each needs at least a code review request, zero or more feedback, and one yes as the record that it is reviewed. Thanks, Max > On May 9, 2019, at 11:53 PM, Nico Williams <nico.willi...@twosigma.com> wrote: > > On Thu, May 09, 2019 at 12:43:04PM +0800, Weijun Wang wrote: >> Also, all your comments and responses posted in the previous mail are >> on files but not on a specific bug. Now that all bugs/RFEs are created >> [...] > > When I'm done making the changes I agreed to make, I'll make sure to > have a "fixup" commit for each change naming the original commit it is > modifying so that you'll be able to see those changes, then we can > squash them later. > > If you have not reviewed any of my contribution yet, then I might as > well just squash the changes I make in response to external code review. > > Nico > --
