Reading the Set spec, it looks like an NPE is still needed for add(), but remove() can be modified.
--Max > On Apr 27, 2020, at 10:27 PM, Sean Mullan <sean.mul...@oracle.com> wrote: > > The fix looks fine to me. For consistency, you could make the same change for > null elements in the other SecureSet methods: add, remove. > > --Sean > > On 4/25/20 3:39 AM, Weijun Wang wrote: >> Please take a review at >> http://cr.openjdk.java.net/~weijun/8243592/webrev.00/ >> This is helpful if we do any set arithmetic between 2 Subject objects. >> No new regression test, I intend to add a noreg-trivial label. >> *Tigran*: Please confirm you are OK with the "Contributed-by" line. >> Thanks, >> Max
