Can you update the existing TimeStampCheck test to use this class? I know that test can simulate some error conditions. Maybe you can add one or more virtual methods in this class so TimeStampCheck can override them.
getDefaultSigAlgo(): Please call AlgorithmId.getDefaultSigAlgForKey() instead. It will be enhanced to support new algorithm. Param: How about making it a JDK 14 record? Thanks, Max > On May 9, 2020, at 11:29 AM, Weijun Wang <[email protected]> wrote: > > Please take a review at > > https://cr.openjdk.java.net/~weijun/8244674/webrev.00 > > I've consolidated 2 old tests into one and added a new case. > > Thanks, > Max >
