On Wed, 7 Oct 2020 19:42:11 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 664: >> >>> 662: * engineUpdate() and engineDoFinal(). >>> 663: */ >>> 664: private int bufferCrypt(ByteBuffer input, ByteBuffer output, >> >> It looks like this method is copied from the CipherSpi. For maintenance, it >> would be nice to add an extra comment to >> state the copy and update. For example, "this method and implementation is >> copied from javax.crypto.CipherSpi, with an >> improvement for GCM mode." > > Agree w/ Xuelei, it'd be nice to mention CipherSpi.bufferCrypt() method. In > case a bug is found, it'd be checked and > fixed in both places. Yeah.. good point. ------------- PR: https://git.openjdk.java.net/jdk/pull/411
