On Fri, 30 Oct 2020 21:39:42 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java >> line 1095: >> >>> 1093: addMech(CKM_SP800_108_FEEDBACK_KDF, >>> "CKM_SP800_108_FEEDBACK_KDF"); >>> 1094: addMech(CKM_SP800_108_DOUBLE_PIPELINE_KDF, >>> 1095: >>> "CKM_SP800_108_DOUBLE_PIPELINE_KDF"); >> >> same comment as above. > > Well, per the ordering in PKCS11Constants, these three lines are at the right > place. Note that the ordering of CKM_ECDSA_SHA3_224 to CKM_EDDSA in pkcs11t.h > is different from PKCS11Constants class, so I will add the comment about the > general ordering following PKCS11Constants class and keep them here. Sounds good that a comment will be added. ------------- PR: https://git.openjdk.java.net/jdk/pull/917
