On Fri, 13 Nov 2020 20:54:15 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Code review comment update >> Major change to test to detect corruption with incremental buffers test > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 507: > >> 505: processAAD(); >> 506: // 'len' stores the length to use with buffer 'in'. >> 507: // 'inLen' stores the length returned by the method. > > line 551 has "return len;" which seems conflicting with these two-line > comments here? The comment is backwards. I wrote the comment before I decided to switch the meaning of the variables and never updated the comment ------------- PR: https://git.openjdk.java.net/jdk/pull/411
