On Fri, 6 Nov 2020 23:02:54 GMT, Valerie Peng <[email protected]> wrote:
>> If the output buffer provided is not big enough, it creates an internal one. >> Two things happened here, one the variable was renamed because I felt >> "outWithPadding" was misleading. The second was to only create this buffer >> when the length was smaller than the estimated length. Before this change >> it would already create and use this buffer whether it was needed or not. > > I understand the renaming and etc. The difference here is that if output > buffer is large enough, then the padding bytes are written into the output > buffer even though the returned output length does not count them. Before > this change, a separate output buffer is always used. Do you think it's ok to > output padding bytes into user-supplied buffer? This is my main concern about > this line. With me reverting padding ciphers to having a copy again, this should not be a concern. ------------- PR: https://git.openjdk.java.net/jdk/pull/411
