On Wed, 18 Nov 2020 18:53:21 GMT, Weijun Wang <[email protected]> wrote:
>> This is a micro benchmark for various algorithm settings of PKCS keystores.
>> Strong for new algorithms and weak for old ones. Different iteration counts
>> are tried. The result should show that the current setting (strong10000) is
>> more efficient than old setting (weak50000).
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> not static anymore
I like it, thanks. Minor nit follows.
test/micro/org/openjdk/bench/java/security/PKCS12KeyStores.java line 46:
> 44: public class PKCS12KeyStores {
> 45:
> 46: static char[] pass = "changeit".toCharArray();
This is still a bit weird: is it a constant? Then this should probably be:
static final char[] PASS = "changeit".toCharArray();
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1277
