On Thu, 19 Nov 2020 07:58:36 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> not static anymore
>
> test/micro/org/openjdk/bench/java/security/PKCS12KeyStores.java line 46:
>
>> 44: public class PKCS12KeyStores {
>> 45:
>> 46: static char[] pass = "changeit".toCharArray();
>
> This is still a bit weird: is it a constant? Then this should probably be:
> static final char[] PASS = "changeit".toCharArray();
Yes, it should be. I'll include the change in the next push. Thanks for
reviewing.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1277
