On Tue, 30 Mar 2021 21:49:57 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Avoid overriding buffered bytes with padding in the doFinal call. >> - Only do encryption block-size buffering for NSS >> - 8261355: No data buffering in SunPKCS11 Cipher encryption when the >> underlying mechanism has no padding > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java line > 606: > >> 604: // NSS throws up when called with data not in >> multiple >> 605: // of blocks. Try to work around this by holding the >> 606: // extra data in padBuffer. > > nit: The comment looks a little bit strange. This particular block of code is > for handling existing buffered data buffered in earlier update() calls. The > comment however is more about 'reqBlockUpdates' itself. How about merging > this with the comment for 'reqBlockUpdates' field and then changing this > comment to what this particular block of code does. Yes, you are right. I merged the comment with the field description. I believe there is not much to say about that block, though. At least there is nothing new there, except that we may buffer for reqBlockUpdates reasons. If you still want a comment there, let me know and I try to figure out something. ------------- PR: https://git.openjdk.java.net/jdk/pull/2510
