On Wed, 9 Jun 2021 17:43:45 GMT, Evan Whelan <ewhe...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 590: >> >>> 588: // ignore the exception >>> 589: if (SSLLogger.isOn && SSLLogger.isOn("ssl")) { >>> 590: SSLLogger.warning("SSLSocket duplex close failed. >>> Debug info only. Exception details:", ioe); >> >> If this is a debug message, shouldn't we just use `SSLLogger.fine()` instead >> of `SSLLogger.warning()`, with the same message "SSLSocket duplex close >> failed"? @coffeys what do you think? > > Hi @seanjmullan @coffeys > > I also don't have a logging level preference, so if there's merit to changing > it, I'll be happy to do so. > I've updated the test case and verified it passes on all platforms. > > Looking forward to any further feedback :) Ok, It sounds like whether it should be a different logging level (fine) or not can be handled separately as part of a more global effort across other SSL logging messages. So I am ok with the change as-is. ------------- PR: https://git.openjdk.java.net/jdk/pull/4354