On Wed, 9 Jun 2021 17:46:42 GMT, Evan Whelan <ewhe...@openjdk.org> wrote:
>> Hi,
>>
>> Please review my fix for JDK-8255148 which clarifies when an exception
>> contains debug information only.
>>
>> Regards,
>> Evan
>
> Evan Whelan has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Added new line at end of file
> - Cleaned up test case
src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1332:
> 1330: // ignore the exception
> 1331: if (SSLLogger.isOn && SSLLogger.isOn("ssl")) {
> 1332: SSLLogger.warning("output stream close failed.
> Debug info only. Exception details:", ioe);
I may look at this bug report different. It is a problem that the user does
not understand the debug log properly. Debug log is for debug information
only, and the debug log level indicates the level of the message.
It looks like there is too much duplicated information. A log message has
already indicated that the message is debug information only. Otherwise,
exception should has been thrown in application level. The adding of
"Exception details:" adds unnecessary dependency of the exception logging
format.
It may be fine to keep it unchanged, as if the users understand the logging
message and logging levels. This kind of information normally means there is
something that an application should take care of. That why we use a warning
level log, rather than a fine level log message.
It we really want an update, may be we could have a documentation enhancement
instead.
Similar comments for other update.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4354
