On Wed, 9 Jun 2021 20:19:12 GMT, Jack Hartstein
<github.com+44308314+jackh2...@openjdk.org> wrote:
> The RC5ParameterSpec class description contains the following sentence: "This
> class can be used to initialize a Cipher object that implements the RC5
> algorithm as supplied by RSA Security LLC, or any parties authorized by RSA
> Security."
>
> The part "as supplied by RSA Security LLC, or any parties authorized by RSA
> Security." should be removed. We don't generally include information about
> 3rd-party JCA providers in the standard javadocs. Also the "authorized" part
> was probably referring to the RC5 patent but that has since expired.
I was also wondering about the CSR, check with the CSR folks.
src/java.base/share/classes/javax/crypto/spec/RC5ParameterSpec.java line 39:
> 37: *
> 38: * <p> This class can be used to initialize a {@code Cipher} object that
> 39: * implements the <i>RC5</i> algorithm as specified in <a
> href="https://datatracker.ietf.org/doc/html/rfc2040";>RFC 2040</a>.
Try to keep lines to <= 80 chars. Maybe break after "in"
-------------
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4443
