On Mon, 20 Sep 2021 14:28:11 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Add some more comments in the PKIX date() and timestamp() methods. >> Remove extra newline from debugging output. >> - Revert "Revert "Initial revision."" >> >> This reverts commit 4601bbb301455a5e35a3e9d691f791972cdd8204. >> - Remove. >> - Revert "Initial revision." >> >> This reverts commit d49ba3f0aaec51768298fe2247f53ffcbeb7c442. > > src/java.base/share/classes/sun/security/util/JarConstraintsParameters.java > line 114: > >> 112: >> 113: // extract last certificate and key from chain >> 114: private void init(CertPath cp) { > > The `init` name suggests it's only done once at the beginning, but actually > it's an accumulation process. Can we find another name? I have renamed it to `addToCertsAndKeys`. ------------- PR: https://git.openjdk.java.net/jdk/pull/5320