On Thu, 24 Mar 2022 18:58:28 GMT, Valerie Peng <[email protected]> wrote:
>> Can someone help review this update to the PSSParameterSpec class regarding
>> the constructor with int argument and the DEFAULT static field? Just added
>> @Deprecate javadoc tag and caution about their usage as suggested in the bug
>> record.
>>
>> A CSR will be filed once the wording changes are reviewed.
>>
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated to address review feedbacks.
src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 74:
> 72: * TrailerField -- 1
> 73: *
> 74: * <p>Its values are based on the default values in the ASN.1 encoding
Maybe "defined in the ASN.1..."?
src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 75:
> 73: *
> 74: * <p>Its values are based on the default values in the ASN.1 encoding
> 75: * from PKCS#1 standard and may become obsolete as time progresses.
Either "the PKCS#1 standard" or simply "PKCS#1" sounds good, but "PKCS#1
standard" without "the"?
src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 76:
> 74: * <p>Its values are based on the default values in the ASN.1 encoding
> 75: * from PKCS#1 standard and may become obsolete as time progresses.
> 76: * Please do not rely on PSSParameterSpec.DEFAULT unless these values are
Put `PSSParameterSpec.DEFAULT` in `{@code...}`?
-------------
PR: https://git.openjdk.java.net/jdk/pull/7913
