On Fri, 25 Mar 2022 01:33:12 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More minor edits.
>
> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 78:
>
>> 76: * Please do not rely on {@code PSSParameterSpec.DEFAULT} unless these
>> 77: * values are really what you want to use.
>> 78: *
>
> I just read the whole class spec. Since the default values are already
> included on lines 38-41, I think there is no need to use so much words and we
> can just say "defined above".
I am not sure if everyone reads the complete spec from class to fields and
methods. Which part do you want to remove and just use "defined above"?
Personally, I find "above" kind of vague... It's better to keep the comment
near the field. Perhaps we should trim the class spec instead?
-------------
PR: https://git.openjdk.java.net/jdk/pull/7913
