On Fri, 15 Apr 2022 15:50:19 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> This is an effort to fix a problem introduced in the fix for >> [JDK-8284368](https://bugs.openjdk.java.net/browse/JDK-8284368), which >> replaced the finalizers in jdk.crypto.cryptoki with Cleaners. However, >> there is a problem with the code changes. The Runnables registered with >> Cleaner refer to the object being registered ('this'). Meaning, the Cleaner >> mechanism will keep the objects reachable, preventing them from being >> cleaned and collected. > > Xue-Lei Andrew Fan has updated the pull request incrementally with one > additional commit since the last revision: > > add a reference to the clean up method src/jdk.crypto.cryptoki/unix/native/libj2pkcs11/p11_md.c line 274: > 272: ModuleData *moduleData = jlong_to_ptr(ckpNativeData); > 273: > 274: if (moduleData != NULL) { The check should be (moduleData->hModule != NULL)? ------------- PR: https://git.openjdk.java.net/jdk/pull/8248
