On Tue, 26 Apr 2022 11:54:36 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Did you mean pName? The dispose() method will reset it to zero. 'pName" is >> used a lot in native implementation. It may be doable to make it final, but >> it may be more complicated than I could expect. I would like to leave it as >> it is in this PR. > > IMO, there's no need to reset it to zero in `dispose()`. As for the usage in > native implementation, if there is really a case that it gets updated, then > the cleanable you registered at the beginning will be useless. Isn't that a > real problem? The native code does not update pName. As dispose is public, if pName is set to zero, I'm not sure if there is compatibility issues if more methods get called after dispose(). If you are confident with that, I could set pName to final and update the dispose() impl. ------------- PR: https://git.openjdk.java.net/jdk/pull/8136
