On Tue, 26 Apr 2022 15:45:47 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Ok, then I would suggest changing the name of the test as it is misleading. >> I suggest creating a directory named "PasswordCallback" and then adding a >> test named perhaps "CheckCleanerNotBoundToThis" or something like that. I >> would change the name of the `checkClearing` method as you are not checking >> if passwords are cleared. Also update the @summary to describe what it is >> actually testing. Use code comments if you need to explain it further. > > The test has two case now. One is used to check the PasswordCallback object > collection at finalization. The other one is check the password clearing for > clearPassword() method. Is it better to split into two test files so that > the class name could be better fit the purpose? Never mind, I'm splitting the test case into two. ------------- PR: https://git.openjdk.java.net/jdk/pull/8272
