On Wed, 27 Apr 2022 02:33:24 GMT, Bernd <d...@openjdk.java.net> wrote:

>> src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp line 419:
>> 
>>> 417:             __leave;
>>> 418:         }
>>> 419:         if ((pszCertStoreLocation = 
>>> env->GetStringUTFChars(jCertStoreLocation, NULL))
>> 
>> Would it be easier to use a int argument here, it’s a internal api with only 
>> two enumerated Types. That safes the jstring conversion and the Strcmp.
>
> And also, is there a ReleaseString missing?

Thanks for the feedback, I'm going to incorporate that into the PR

-------------

PR: https://git.openjdk.java.net/jdk/pull/8211

Reply via email to