On Thu, 12 May 2022 03:28:15 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> This change refactors the PBES2Core and PKCS12PBECipherCore classes in >> SunJCE provider as requested in the bug record. Functionality should remain >> the same with a clearer and simplified code/control flow with less lines of >> code. This should improve readability and maintenance. I enhanced one >> existing regression test to test more scenarios. This test would pass before >> the proposed change and continues to pass with the proposed changes. > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > trivial syntax fix. LGTM. src/java.base/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java line 363: > 361: return core.implGetParameters(); > 362: } > 363: @Override These 3 methods are the same in 3 classes. I wish we had a way to simplify this but I don't know myself. ------------- Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8521
