On Thu, 12 May 2022 15:03:40 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> trivial syntax fix. > > src/java.base/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java > line 363: > >> 361: return core.implGetParameters(); >> 362: } >> 363: @Override > > These 3 methods are the same in 3 classes. I wish we had a way to simplify > this but I don't know myself. Me neither. However, the refactoring is already reduced quite some code (~300 lines less for the two PBE classes), just can't be 100% lean. ------------- PR: https://git.openjdk.java.net/jdk/pull/8521
