On Fri, 10 Jun 2022 16:19:05 GMT, Hai-May Chao <hc...@openjdk.org> wrote:

>> Please review a small fix in CryptoPolicyParser class that it should not 
>> pass “processedPermissions” parameter by value.
>> Ran MACH5 tier1 and tier2 without failures.
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fixed copyright

test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 38:

> 36: import java.security.Security;
> 37: 
> 38: // This is a manual test to test a custom “default_local.policy" 
> containing inconsistent entries

Thanks for the instructions. For manual test, I would rather have these as a 
System.out on test start than a comment here. This helps engineers who look at 
jtr file for failure analysis as they generally won't refer test source code to 
understand missing steps.

-------------

PR: https://git.openjdk.org/jdk/pull/8985

Reply via email to