On Thu, 25 Aug 2022 15:01:28 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update test to use SHA256 and DSA throughout. > > test/jdk/java/security/Security/ProviderFiltering.java line 89: > >> 87: doit(key + ":" + valComp2 + " ", p); >> 88: // 4. partial value, e.g. class name only >> 89: doit(key + ":" + valComp2CN, p); > > Do we really need to support cases 2-4? In fact, the only place mentioning > spaces in the spec is about the ones between "SHA256withDSA" and > "SupportedKeyClasses". I'd rather you add a test case on it. I can go either way, just try to be more accommodating. Maybe that's not necessary. I will remove them and add the case of extra spaces between algName and attrName. ------------- PR: https://git.openjdk.org/jdk/pull/10008
