On Mon, 29 Aug 2022 15:42:17 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Existing provider filtering code only handles two standard attribute >> "KeySize" and "ImplementedIn", the rest are compared by exact match. Over >> time, more standard attributes are added which contain multiple values >> separated by "|". We should enhance the provider filtering code to better >> compare these. >> >> Documentation update for this is tracked separately under >> https://bugs.openjdk.org/browse/JDK-6447817. >> >> Thanks in advance for review~ > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > remove obsolete println. src/java.base/share/classes/java/security/Security.java line 872: > 870: * and remove those which do not contain a match. > 871: */ > 872: private static void applyFilterOnCandidates(Criteria cr, Can you stuff all these methods into the `Criteria` class? ------------- PR: https://git.openjdk.org/jdk/pull/10008