On Wed, 7 Sep 2022 17:23:58 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> I see that null is returned instead of an empty Provider array. When an >> empty filter map is specified, I interpret it as no criteria is set and thus >> it should return all providers (which is often non-empty). The condition on >> line 599 is OR, but the line on 600 returns the "allProvider" value which >> may or may not be null. Anyway, I start to get the feeling that we may not >> be talking about the same stuff... > > Maybe. But, while all providers is usually non-empty, it could be if a user > remove all of them. I understand this is a just corner case. So, is it about empty all Providers or empty filter map? I only added the check on latter. Are you suggesting to add a check for the former? ------------- PR: https://git.openjdk.org/jdk/pull/10008
