Hi, May I have this simple code clean-up patch reviewed?
In the AES cipher implementation, the override of engineDoFinal() method in the following code is not necessary as it only calls super. The throws descriptions are missed in the method description. I may be better to remove this override implementation, rather than fix the method description. /** * Finalize crypto operation with ByteBuffers * * @param input the input ByteBuffer * @param output the output ByteBuffer * * @return output length * @throws ShortBufferException * @throws IllegalBlockSizeException * @throws BadPaddingException */ protected int engineDoFinal(ByteBuffer input, ByteBuffer output) throws ShortBufferException, IllegalBlockSizeException, BadPaddingException { return super.engineDoFinal(input, output); } ``` Code clean-up, not new regression test added. Thanks, Xuelei ------------- Commit messages: - 8294734: Redundant override in AES implementation Changes: https://git.openjdk.org/jdk/pull/10545/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10545&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294734 Stats: 18 lines in 1 file changed: 0 ins; 18 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10545.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10545/head:pull/10545 PR: https://git.openjdk.org/jdk/pull/10545