On Mon, 3 Oct 2022 19:18:20 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
> Hi,
>
> May I have this simple code clean-up patch reviewed?
>
> In the AES cipher implementation, the override of engineDoFinal() method in
> the following code is not necessary as it only calls super. The throws
> descriptions are missed in the method description. It may be better to
> remove this override implementation, rather than fix the method description.
>
>
> /**
> * Finalize crypto operation with ByteBuffers
> *
> * @param input the input ByteBuffer
> * @param output the output ByteBuffer
> *
> * @return output length
> * @throws ShortBufferException
> * @throws IllegalBlockSizeException
> * @throws BadPaddingException
> */
> protected int engineDoFinal(ByteBuffer input, ByteBuffer output)
> throws ShortBufferException, IllegalBlockSizeException,
> BadPaddingException {
> return super.engineDoFinal(input, output);
> }
>
> ```
>
> Code clean-up, not new regression test added.
>
> Thanks,
> Xuelei
LGTM.
I'm definitely guilty of not taking the time to beautify the method/exception
description from the superclass.
-------------
Marked as reviewed by wetmore (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10545
