On Tue, 1 Nov 2022 23:21:57 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> invalidkeyexception and some review comments > > src/hotspot/share/runtime/globals.hpp line 241: > >> 239: "Use intrinsics for java.util.Base64") >> \ >> 240: >> \ >> 241: product(bool, UsePolyIntrinsics, false, >> \ > > I'm not a fan of introducing new flags for individual intrinsics (there's > already `-XX:DisableIntrinsic=_name` specifically for that), but since we > already have many, shouldn't it be declared as a diagnostic flag, at least? Started removing the option, but its quite convenient to have the boolean global, so just made the option diagnostic. "done" ------------- PR: https://git.openjdk.org/jdk/pull/10582
