On Wed, 9 Nov 2022 00:10:48 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix 32-bit build > > src/hotspot/share/opto/library_call.cpp line 7014: > >> 7012: const TypeKlassPtr* rklass = >> TypeKlassPtr::make(instklass_ImmutableElement); >> 7013: const TypeOopPtr* rtype = >> rklass->as_instance_type()->cast_to_ptr_type(TypePtr::NotNull); >> 7014: Node* rObj = new CheckCastPPNode(control(), rFace, rtype); > > FTR it's an unsafe cast since it doesn't involve a runtime check from > `IntegerModuloP` to `ImmutableElement`. Please, lift as much checks into Java > wrapper as possible. @iwanowww just to save some of your time... Sandhya suggested another way to move the checks to Java, hopefully without too much penalty to non-intrinsic path. Should upload it later today. ------------- PR: https://git.openjdk.org/jdk/pull/10582
