On Mon, 21 Nov 2022 19:06:49 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Jamil Nimeh has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pull out common macro code into function parameter pack
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_chacha.cpp line 107:
>
>> 105: if (VM_Version::supports_evex()) {
>> 106: StubRoutines::_chacha20Block = generate_chacha20Block_avx512();
>> 107: } else { // Either AVX or AVX2 is supported
>
> Worth to supplement the comment with an assert (either `UseAVX > 0` or
> `VM_Version::supports_avx() == true`).
Good catch. This has been implemented.
-------------
PR: https://git.openjdk.org/jdk/pull/7702
