On Thu, 8 Dec 2022 19:33:09 GMT, Rajan Halade <rhal...@openjdk.org> wrote:
>> This fix is intended to address various time-out errors in tests that use
>> DTLSOverDatagram as a test template. Based on test output from those bugs
>> (JDK-8202059, JDK-8249562, JDK-8280185, JDK-8280186, JDK-8269887,
>> JDK-8268899), this fix:
>>
>> * refactors the class to only create one additional thread
>> * adds a CountdownLatch so if the server thread doesn't start for some
>> reason, it is reported quickly
>> * cleans up code to remove a loop condition that never fired: tests always
>> time-out before too many loop iterations
>> * removes CipherSuite.java from ProblemList
>>
>> Ran the following tests 200 times each with no failures.
>> * open/test/jdk/javax/net/ssl/DTLS/ClientAuth.java
>> * open/test/jdk/javax/net/ssl/DTLS/PacketLossRetransmission.java
>> * open/test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java
>> * open/test/jdk/javax/net/ssl/DTLS/InvalidCookie.java
>> * open/test/jdk/javax/net/ssl/DTLS/CipherSuite.java
>
> test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java line 617:
>
>> 615: clientException = e;
>> 616:
>> 617: if (testCase.isGoodJob()) {
>
> Same here. Check if this is method is even used and what is the purpose of
> it. You may not need these checks and would prefer to have no try-catch in
> this method.
It is used by InvalidRecords.java test. It expects handshake to fail so
overrides this method.
-------------
PR: https://git.openjdk.org/jdk/pull/11558
