On Thu, 8 Dec 2022 19:40:12 GMT, Rajan Halade <[email protected]> wrote:
>> test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java line 617:
>>
>>> 615: clientException = e;
>>> 616:
>>> 617: if (testCase.isGoodJob()) {
>>
>> Same here. Check if this is method is even used and what is the purpose of
>> it. You may not need these checks and would prefer to have no try-catch in
>> this method.
>
> It is used by InvalidRecords.java test. It expects handshake to fail so
> overrides this method.
refactored the code to be a bit cleaner.
The InvalidRecords.java test explicitly threw an exception that is then treated
as a successful test run. I refactored the test a little so it only throws an
exception if the test fails.
-------------
PR: https://git.openjdk.org/jdk/pull/11558
