On Fri, 3 Feb 2023 19:32:52 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge branch 'openjdk:master' into comments >> - Partial Revert >> - sspi.cpp >> - Comments > > src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 31: > >> 29: // This library can be built directly with the following command: >> 30: // cl -I %OPENJDK%\src\java.security.jgss\share\native\libj2gss\ >> sspi.cpp >> 31: // -link -dll -out:sspi_bridge.dll > > I think the backslash `` should remain there: it's a command line and `` is > used to wrap the long line. I did think about that too when I first saw it, but the command this is often run from is the Windows CMD, which does not accept `` to escape to the next line. MSYS bash does not have the required environment set up outside of configure time to run `cl` either, but I have not tested with WSL yet. I suppose one could do the complicated setup required to be able to run this from the winenv provided bash, but that seems like a lot of hassle, enough that to me someone trying to compile sspi_bridge.dll by itself wouldn't really bother with the process. On top of that cl.exe will actually interpret the backslash as the literal object file `.o` for some weird reason. I've already pinged the original author of the file @wangweij above to ask for guidance on this as such ------------- PR: https://git.openjdk.org/jdk/pull/12305
